Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reduce latency to process messages #161

Merged
merged 11 commits into from
Nov 11, 2022
Merged

feat: reduce latency to process messages #161

merged 11 commits into from
Nov 11, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 11, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 11, 2022 •
edited
Loading

Codecov Report

Base: 82.28% // Head: 82.15% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (5c3c4e7) compared to base (9240bfd).
Patch coverage: 81.25% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   82.28%   82.15%   -0.14%     
==========================================
  Files          27       27              
  Lines        3127     3132       +5     
  Branches      645      645              
==========================================
  Hits         2573     2573              
- Misses        339      342       +3     
- Partials      215      217       +2
Impacted Files Coverage Δ
src/dbus_fast/message_bus.py 71.27% <81.25%> (+0.26%) ⬆️
src/dbus_fast/glib/message_bus.py 80.32% <0.00%> (-2.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

bdraco
bdraco commented Nov 11, 2022
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
bdraco
bdraco commented Nov 11, 2022
View reviewed changes
src/dbus_fast/message_bus.py Outdated Show resolved Hide resolved
bdraco
bdraco commented Nov 11, 2022
View reviewed changes
src/dbus_fast/message_bus.py Outdated Show resolved Hide resolved
@bdraco bdraco changed the title feat: add basic pxd file for message_bus.py feat: Improve message_bus.py _process_message performance with a basic pxd file Nov 11, 2022
@bdraco bdraco changed the title feat: Improve message_bus.py _process_message performance with a basic pxd file feat: Improve message_bus.py _process_message performance with a pxd file Nov 11, 2022
@bdraco bdraco changed the title feat: Improve message_bus.py _process_message performance with a pxd file feat: Improve message_bus.py _process_message performance with a pxd file Nov 11, 2022
@bdraco
Copy link
Member Author

bdraco commented Nov 11, 2022 

Nov 11 14:14:54 homeassistant homeassistant[471]: 2022-11-11 08:14:54.221 DEBUG (MainThread) [aiohomekit.controller.ble.pairing] Qingping Temp RH H [D3:2C:5A:5B:53:13] (id=CA:CC:78:DE:9D:4D): Subscribing to gatt notify for iid: 60
Nov 11 14:14:54 homeassistant homeassistant[471]: 2022-11-11 08:14:54.321 DEBUG (MainThread) [aiohomekit.controller.ble.pairing] Qingping Temp RH H [D3:2C:5A:5B:53:13] (id=CA:CC:78:DE:9D:4D): Subscribing to gatt notify for iid: 59
Nov 11 14:14:54 homeassistant homeassistant[471]: 2022-11-11 08:14:54.421 DEBUG (MainThread) [aiohomekit.controller.ble.pairing] Qingping Temp RH H [D3:2C:5A:5B:53:13] (id=CA:CC:78:DE:9D:4D): Subscribing to gatt notify for iid: 145
Nov 11 14:14:54 homeassistant homeassistant[471]: 2022-11-11 08:14:54.521 DEBUG (MainThread) [aiohomekit.controller.ble.pairing] Qingping Temp RH H [D3:2C:5A:5B:53:13] (id=CA:CC:78:DE:9D:4D): Subscribing to gatt notify for iid: 257

We are able to keep up with the 100ms buffer on the CSRs now almost every time

@bdraco bdraco marked this pull request as ready for review November 11, 2022 14:15
@bdraco bdraco changed the title feat: Improve message_bus.py _process_message performance with a pxd file feat: reduce latency to process messages Nov 11, 2022
@bdraco bdraco merged commit 113f0c9 into main Nov 11, 2022
@bdraco bdraco deleted the message_bus_cython branch November 11, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco